search

fraz3alpha / running-challenges

An extension to allow you to complete challenges with your parkrun results
Other
36 stars 20 forks source link

Update results table name and volunteer roles for parkrun.pl #362

Closed rboyatt closed 1 year ago

rboyatt commented 2 years ago

Resolves #361 - updating the name of the results table on parkrun.pl and updates volunteer role names. I've identified new role names by looking at the following parkrun.pl event volunteer pages:

And looking at the notes available on https://support.parkrun.com/hc/en-us/articles/360000631477. I am not a Polish speaker and while I think it's correct, it would be useful to have it validated by a native speaker. I've also added new role names, rather than replaced the older role names entirely.

zbir84 commented 2 years ago

I'm not that familiar with the code you have here, but from the Polish -> English language perspective the mapping looks good.

rboyatt commented 2 years ago

Thanks for checking through @zbir84 - very much appreciated. And thanks @sarahdavis23 for making the connection.

fraz3alpha commented 1 year ago

Thanks everyone! I'm going to try and extend the basic test to include the .pl site, so I'll merge this in, and see if it makes my tests pass - but even if it doesn't, it looks like an improvement, thanks everyone :)