search

frc-4931 / 2014-Design

The files, issues, wiki pages, etc. for the design of our 2014 FIRST Robotics Competition robot
MIT License
1 stars 0 forks source link

StudentsWithWrite do not have access to 2014-Robot #77

Closed agausmann closed 10 years ago

agausmann commented 10 years ago

Zach and I found a small issue with our member groups a couple of days ago. Students group has access to frc-4931/2014-Robot, but StudentsWithWrite do not. Since I was not added to the Students group, I don't have access to that repository.

rhauch commented 10 years ago

Apologies for not including you in 'Students'. The 2014-Robot repository specifically uses 'Students' that does not grant push privileges: we use pull-requests for all code changes and don't create issues in that repo, so there's no need for anybody to have push privilege.

Granting push-privilege to our codebase allows students that may have little Git experience to do something dangerous. Yes, Git maintains all history, so it's difficult to lose things. But Git is also very powerful and will let you do something really bad, like rewrite history. So recovering from accidents can still be time-consuming and difficult. It's far easier to limit who has push privilege.

BTW, this is a very common practice in the open source world: on a project only a few people will have push privilege because anyone can still read the code, submit patches, and (with GitHub) pull-requests with changes ready to be merged in. It's referred to as "benevolent dictatorship".

agausmann commented 10 years ago

Yeah, sorry. I accidentally added an extra "push" into my original post.

rhauch commented 10 years ago

LOL. No worries. BTW, you should have read access to 2014-Robot and full access to the other repos (including 2014-Design).

rhauch commented 10 years ago

@AGausmann, please close this if you think it's resolved. Thanks!