search

frc-frecon / frecon

An API for building scouting apps for FRC competitions
MIT License
3 stars 0 forks source link

Team Logo Path #17

Closed Sammidysam closed 10 years ago

Sammidysam commented 10 years ago

I would like to add the line

field :logo_path, type: String

to models/team.rb.

Is this fine? I feel like teams have logos often enough that it doesn't need to be extra data on the team. It will be an optional attribute, but it would be nice to have a standard for a string that can be used to load the logo image for the team.

cg505 commented 10 years ago

I highly doubt anyone will ever use that, but I guess it can't hurt.

Sammidysam commented 10 years ago

The use case that I was thinking of was that in our implementation in the teams.html page we have a box for each team, and it would look simply beautiful if we filled that box with the team logo if it is present.

cg505 commented 10 years ago

I agree. But I would not want to go track down all the logos for all the teams. A better idea might be to use robot photos from prescouting.

This isn't saying not to implement it, by any means. I'm simply saying that I think the benefit would be very small.

Sammidysam commented 10 years ago

I think others might want a standard because most teams have logos. I'll add it.