frc1418 / 2017-robot

:robot: Team 1418's FRC robot code for the 2017 season
MIT License
6 stars 4 forks source link

Add gearpicker module #10

Closed ErikBoesen closed 7 years ago

ErikBoesen commented 7 years ago

Should be working now.

ArchdukeTim commented 7 years ago

I think the only thing left would be to change the name from actuate_up to pivot_up

ErikBoesen commented 7 years ago

Should be good now. Go to rebase/merge?

ArchdukeTim commented 7 years ago

Yeah. I would say in the future don't include whitespace removal in these commits. Make them their own. Or better yet, get that travis put up so we don't have it 😂

ErikBoesen commented 7 years ago
ArchdukeTim commented 7 years ago

Dustin said theres a way to get an education thing

ErikBoesen commented 7 years ago

I contacted support and apparently there's not. Perhaps I missed something though.

CarterFendley commented 7 years ago

Erik, please if you insists upon doing the white space thing then make it a separate commit. It is incredibly difficult to see what you actually changed in this PR.

CarterFendley commented 7 years ago

Didn't mean to close. Erik you should be using git add filename.txt not git add -A this prevents adding of files you didn't change like swervedrive and swervemodule. If you want to use git add -A at least just use git commit and in the dialog it will list the changed files you are about to commit. You should always check this and do a git rest HEAD if you added the wrong files.

ErikBoesen commented 7 years ago

As I said, this was an accident, if I do this in the future I will make sure to keep it separate. Do you want me to redo the commit?

CarterFendley commented 7 years ago

Yes, this is a PR about gearpicker.py and robot.py. Please remove the other files. If you want to make a separate PR fixing the whitespace in other files I will merge that one separately.

ErikBoesen commented 7 years ago

Create GearPicker class

ErikBoesen commented 7 years ago

Updated to not include Swerve whitespace removal.

ArchdukeTim commented 7 years ago

PS, adding ?w=1 to the url won't show whitespace changes in the even there are some