Closed ErikBoesen closed 7 years ago
I think the only thing left would be to change the name from actuate_up
to pivot_up
Should be good now. Go to rebase/merge?
Yeah. I would say in the future don't include whitespace removal in these commits. Make them their own. Or better yet, get that travis put up so we don't have it 😂
Dustin said theres a way to get an education thing
I contacted support and apparently there's not. Perhaps I missed something though.
Erik, please if you insists upon doing the white space thing then make it a separate commit. It is incredibly difficult to see what you actually changed in this PR.
Didn't mean to close. Erik you should be using git add filename.txt
not git add -A
this prevents adding of files you didn't change like swervedrive and swervemodule. If you want to use git add -A
at least just use git commit
and in the dialog it will list the changed files you are about to commit. You should always check this and do a git rest HEAD
if you added the wrong files.
As I said, this was an accident, if I do this in the future I will make sure to keep it separate. Do you want me to redo the commit?
Yes, this is a PR about gearpicker.py
and robot.py
. Please remove the other files. If you want to make a separate PR fixing the whitespace in other files I will merge that one separately.
Updated to not include Swerve whitespace removal.
PS, adding ?w=1
to the url won't show whitespace changes in the even there are some
Should be working now.