frc1418 / 2017-robot

:robot: Team 1418's FRC robot code for the 2017 season
MIT License
6 stars 4 forks source link

Maybe make swervemodule a class of swervedrive #20

Closed ArchdukeTim closed 7 years ago

ArchdukeTim commented 7 years ago

It may make sense to only allow SwerveDrive to interact with swervemodules. For example, in autonomousPeriodic call SwerveDrive.update_smartdash() and from there call module.update_smartdash()

Thoughts?

CarterFendley commented 7 years ago

The reason that I had them as there own thing is because initializing swerve drive while declaring the swerve modules would be a line longer that one can imagine. I agree with making the swervederive sd update call the modules' sd update. What is in there now was for debugging.

ArchdukeTim commented 7 years ago

Ok