search

frc1418 / 2017-robot

:robot: Team 1418's FRC robot code for the 2017 season
MIT License
6 stars 4 forks source link

Clean up _predict_position #29

Closed ArchdukeTim closed 7 years ago

ArchdukeTim commented 7 years ago

@CarterFendley I started cleaning it up per the TODO

CarterFendley commented 7 years ago

This commit is largely PEP which I don't want to bother about right now. There is a reason I disabled to Travis check. The way you modified the function would also break the math.

ArchdukeTim commented 7 years ago

Um, yeah I saw. My question is why is the math different depending on the wheels? Mostly, why is https://github.com/frc1418/2017-robot/blob/master/robot/components/swervedrive.py#L212 different than https://github.com/frc1418/2017-robot/blob/master/robot/components/swervedrive.py#L237