frc1418 / 2018-robot

:robot: Code for our 2018 competition robot, Panthera.
MIT License
3 stars 2 forks source link

Add magicbot_test #144

Closed ErikBoesen closed 6 years ago

ErikBoesen commented 6 years ago

Fix #143

ArchdukeTim commented 6 years ago

What I would say is go through and fix all of the stuff that is broken, and then come back and merge this

ErikBoesen commented 6 years ago

@twinters007 Yeah, I'll do that.

ErikBoesen commented 6 years ago

@twinters007 The issue is that only one waypoint is being passed to pf.generate. What do I need to do to fix this?

ArchdukeTim commented 6 years ago
pf.generate([pf.Waypoint(0, 0, 0), waypoint],
                                       pf.FIT_HERMITE_CUBIC, pf.SAMPLES_HIGH,
                                       0.05, 1.7, 2.0, 60.0)

That's what I did, although I'm not versed enough with pathfinder to know if this is correct

ErikBoesen commented 6 years ago

That would make sense.

ErikBoesen commented 6 years ago

@twinters007 Okay, the tests are now passing. However, they take a ridiculously large quantity of time to run (mine took 6m40s). Do you have any idea how I can get around this?

ArchdukeTim commented 6 years ago

I don't think there's an easy way. Your computer is slower than mine, so mine only take like, 2 minutes

It has to do with the notifier I'm pretty sure, as well as testing EVERY single possible autonomous (testing all autonomous with all configurations of the field)

ErikBoesen commented 6 years ago

Can we only test in one configuration? Is that possible? I'd rather not test every configuration every time...

ArchdukeTim commented 6 years ago

I stupidly deleted all the changes I made so lemme make sure this is everything I found wrong...although I'm surprised the tests passed without the super call. They should've crashed

ArchdukeTim commented 6 years ago

Ok so after talking with dustin, it turns out that generating pathfinder paths takes a LONG time, so get rid of the second charge auto. That'll really cut down test time

ErikBoesen commented 6 years ago

@twinters007 It's still really slow (~56s for me)...

ArchdukeTim commented 6 years ago

That's probably as god as you're gonna get I think