search

frc2052 / FRC-Krawler

FIRST Robotics scouting app brought to you by Team 2052
MIT License
24 stars 24 forks source link

Added button to reorder items #35

Closed CaptnSisko closed 6 years ago

Adam8234 commented 6 years ago

Although this works, I can see many issues happening with changing the id's of metrics. This could have sync issues with client devices and cause lots of crashing. Rather, I suggest you use the priority column that already exists for Metrics.

alexrallen commented 6 years ago

@CaptnSisko I am the author of this code, it was provided for reference and should not be pushed into production (I noticed you are merging from master). It needs to be rewritten. It is outdated, a temporary hotfix, and not in shape to be merged into a master branch, nor should it be used during the season. I strongly recommend rolling back the commit on your end to prevent issues in the future. I apologize for any confusion.

This pull can probably be closed. Thank you for your comments @Adam8234 !