search

frc2052 / FRC-Krawler

FIRST Robotics scouting app brought to you by Team 2052
MIT License
23 stars 23 forks source link

Match Data LOST during sync. #37

Open TheMatt2 opened 6 years ago

TheMatt2 commented 6 years ago

From testing this weekend, we have seen multiple cases where scouted matches actually don't get logged by the server phone. Initially we thought it was mistakes by people using the phones, but after isolated testing, it was clear that there is actually an issue.

The issue appears to be that if more than one phone tries to sync at once, an error can occur, showing a dialog on the scout phone saying "Could not connect to server, please check the version of the server phone..." (even though the versions were all up to date).

After these errors, if a phone successfully syncs, it shows up in the logs of the server, but as having reported 0 new matches.

When the data is then exported (as raw export), some of the data, is then completely missing! When syncing six scouting phones to a server, we have observed up to 3 phones having their data disappear at once.

The work around is to just not sync multiple phones at once. If done individually, we say much fewer odd disappearances of data (though there was one).

Steps to reproduce.

  1. Take multiple scout phones with FRC Krawler as scout. I used 6 phones.
  2. Take one server phone, with a competition loaded onto it with some metrics.
  3. Sync all of the scouting phones to load the competition and metrics.
  4. Enter a match on each of the phones and save it. (Don't sync yet).
  5. All at once, press sync on all of the scouting phones. This required more than one person to push the buttons fast enough when I did it.
  6. When a sync error occurs on the scout phones for failed to connect. Close the warning and try to sync again. Repeat until syncing is successful.
  7. Use Export Raw to load the data from that event onto a computer.
  8. Observe that there are not 6 matches on the output csv. From my testing there will only be 3 or 4. Where did the others go? That is the problem.
TheMatt2 commented 5 years ago

Is there an update on this?

bherbst commented 5 years ago

@TheGreatKetchup unfortunately @Adam8234 graduated from the team, and we are in still in the process of teaching new students Android development.

If you want to take a crack at fixing the issue, we are more than happy to accept pull requests! Unfortunately I can't provide a timeline on when we will be able to take a look at fixing this issue, but it definitely hasn't fallen off our radar!