frc4039 / 2024

Our 2024 competition robot repo
Other
1 stars 0 forks source link

Remove limelight feed from shuffleboard #144

Closed noahlinton closed 7 months ago

4039-zach commented 7 months ago

This is manually added to each Driver Station individually, and isn't in the code anywhere.

noahlinton commented 7 months ago

@SteveJacka @4039-zach but if we are sending it to the network table, does that still tie up bandwidth?

Should we just remove from the code and use photonvision web interface via tether if we need to look at the limelights?

SteveJacka commented 7 months ago

The stream traffic goes directly from the limelight(server) to the shuffleboard(client). The network table only contains the url used by the client to access the stream. As long as no clients (shuffleboard or web browsers) have the stream open, then there is no significant bandwidth consumed. It's fine to leave the camera server entries in the NT.

Ben-Alderson commented 7 months ago

@noahlinton As they said, the limelight feed isn't coming from the code. We do add the "note detection" camera if that's what you're talking about. But the limelight is not something that gets added by the code.

If you are seeing the limelight feed, it's likely there's a stale entry for the camera on the driver station. Try removing the camera from Shuffleboard before connecting to the robot.

noahlinton commented 7 months ago

OKay thanks for the clarification everyone! Just wanted to make sure I was on the same page.