frc5183 / Oatmeal

MIT License
2 stars 0 forks source link

Batch Removal for Reminders #17

Closed Trip-kun closed 9 months ago

Trip-kun commented 9 months ago

Instead of iterative deletion, use batch deletion to prevent spamming DB requests

Per CodeRabbit: The removeReminderData() method is called inside a loop. If this method involves database operations, it could be inefficient. Consider collecting all IDs to be removed in a list and then removing them in a single batch operation.

This is a VERY easy change as we already collect all IDs