frc868 / 2017-robot

The code for FRC 868's 2017 robot, Ratchet
1 stars 1 forks source link

Feeder canFeed() Bug #101

Open karagenit opened 7 years ago

karagenit commented 7 years ago

If the Feeder is told to start feeding, it checks to see if the shooter is ready to have balls fed. If the Feeder is told to feed while the shooter isn't ready, it simply won't feed, ever. This isn't a big deal in itself, as the Feed command would just have to be run again once the shooter is ready.

The biggest problem occurs with things like the ToggleFeeder/Agitator command. This bug could cause the Agitator and Feeder to get off-sync, meaning that only one can be run at a time.

Solution: Feed command waits for canFeed() to be true, and doesn't return isFinished until canFeed() has returned true.