Search no longer filters results

frctl / fractal

A tool to help you build and document website component libraries and design systems.

https://fractal.build

MIT License

2.11k stars 169 forks source link

Search no longer filters results #1202

Closed rickdoesburg closed 9 months ago

rickdoesburg commented 2 years ago

I'm not exactly sure when this happend but when searching in the sidebar the results do get highlighted but other results won't be hidden.

Fractal version: 1.5.13

Any tips would be appreciated.

makoch01 commented 2 years ago

It looks like that the issue is caused by this line: https://github.com/frctl/fractal/blob/96f5099fef5836f4b91c6865b2bf21c5f6430e6b/packages/mandelbrot/assets/js/components/search.js#L72

If I remove this line in the minified mandelbrot.js everything works as expected.

makoch01 commented 2 years ago

Enabling Split-Navigation in the config navigation: 'split', makes the bug less anoying. The left pane is still broken, but the right one works fine.

janbrasna commented 9 months ago

@rickdoesburg This should be fixed since mandelbrot@1.10.3 in #1252 — try updating to 1.5.15 if that resolves it for you.

rickdoesburg commented 9 months ago

@janbrasna Indeed it has, completely forgot about this open issue.