search

frctl / twig

Use Twig templates with Fractal.
32 stars 34 forks source link

Properly close #13 with version bump and npm publish #16

Closed therealpecus closed 5 years ago

therealpecus commented 5 years ago

Hi @Chapabu ,

I think we need a version bump and npm publish to ensure the fix for #13 is propagated to the registry. Currently, v. 1.0.0-beta.4 still resolves to https://registry.npmjs.org/@frctl/twig/-/twig-1.0.0-beta.4.tgz which is the broken version.

From package-lock.json

    "@frctl/twig": {
      "version": "1.0.0-beta.4",
      "resolved": "https://registry.npmjs.org/@frctl/twig/-/twig-1.0.0-beta.4.tgz",
      "integrity": "sha512-TyP0GOAZQdzYn1Wgy+rfPjFwCWzgWXstRmtMwdBrPFxL4dikPLCShQCralEUCduuini9DQLEsLeUHdeK1F7Cyg==",
      "dev": true,
      "requires": {
        "lodash": "^4.17.10",
        "twig": "^1.12.0"
      }

Thanks!

Chapabu commented 5 years ago

@dkhuntrods Do we want to think about publishing a @next release? I'm apprehensive to make a proper release until the main Fractal release we've got in progress has stabilised. I don't have access to publish to NPM otherwise I'd do it myself :)

Chapabu commented 5 years ago

@therealpecus In the interim you should be able to install directly from Github

therealpecus commented 5 years ago

Yes, that would do. My concern is mainly so that those who hit the buggy release and are still stuck on it can access the fixed code easily.

dkhuntrods commented 5 years ago

@Chapabu, @therealpecus thanks - yep I'm planning on reviewing and syncing all adapters this weekend as well as getting the fractal core circular ref out under a beta tag, which should resolve a lot of issues

dkhuntrods commented 5 years ago

@Chapabu Also I'll look at getting you npm access - I thought you had for some reason! :)

dkhuntrods commented 5 years ago

@Chapabu @therealpecus I've published an @next release: https://www.npmjs.com/package/@frctl/twig/v/1.0.0-beta.5

13