Deploy on push to tag - Githubissues

MOJOliciousFTW commented 1 week ago

GitHub Copilot Summary

This pull request includes a change to the GitHub Actions workflow configuration for deploying a Jekyll site to GitHub Pages. The change modifies the trigger condition for the deployment job.

Trigger condition update:

.github/workflows/deploy.yml: Changed the trigger from pushes to the master branch to tags matching the pattern v*, and added a manual trigger option with workflow_dispatch.

Breaking change

No longer deploying master/default branch.

Proposed change

Deploy on push to tag, or still workflow_dispatch.

Intention is to create a release using with default versioning vx.y.z.

By deploying version, one can report bugs with version number, neato burrito.

After bugs are fixed, one can make a new release and generate release notes, so traceable.

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.

swampbear commented 3 days ago

If i understand this tag correctly does is run the workflow a push tag event am i onto something @MOJOliciousFTW ?

MOJOliciousFTW commented 3 days ago

If i understand this tag correctly does is run the workflow a push tag event am i onto something @MOJOliciousFTW ?

if push to any tag starting with v (example v1.0.0 or v2.3.4), then yes this workflow is ran.