This pull request focuses on restructuring the GitHub Actions workflows for deploying a Jekyll site and removing sensitive information from configuration files. The most important changes include replacing the existing deploy workflow with a new one, removing hardcoded secrets, and cleaning up configuration files.
.github/workflows/jekyll-gh-pages.yml: Added a new workflow with GitHub Pages dependencies preinstalled, including build and deployment jobs, environment variables setup, and concurrency control.
Configuration cleanup:
_config.yml: Removed hardcoded supabase_url and supabase_key from the configuration file.
_config_prod.yml: Deleted the production configuration file, removing all settings and secrets.
Proposed change
Replace deploy workflow with less third party deps.
use only _config.yml and only with secrets. This is only a minor improvement, if any, the secrets are still found on the resulting static site. Secrets are not removed from commit history, that would require cleaning, could also just update the secrets so the old are revoked, but again the secrets are still in the resulting static site so no improvement really.
Also added allow access to tag v* for github-pages environment in repo settings.
Hardly an improvement, but fun to learn a bit.
Type of change
[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
GitHub Copilot Summary
This pull request focuses on restructuring the GitHub Actions workflows for deploying a Jekyll site and removing sensitive information from configuration files. The most important changes include replacing the existing deploy workflow with a new one, removing hardcoded secrets, and cleaning up configuration files.
Changes to GitHub Actions workflows:
.github/workflows/deploy.yml
: Removed the old workflow for deploying the Jekyll site to GitHub Pages..github/workflows/jekyll-gh-pages.yml
: Added a new workflow with GitHub Pages dependencies preinstalled, including build and deployment jobs, environment variables setup, and concurrency control.Configuration cleanup:
_config.yml
: Removed hardcodedsupabase_url
andsupabase_key
from the configuration file._config_prod.yml
: Deleted the production configuration file, removing all settings and secrets.Proposed change
Replace deploy workflow with less third party deps.
use only
_config.yml
and only with secrets. This is only a minor improvement, if any, the secrets are still found on the resulting static site. Secrets are not removed from commit history, that would require cleaning, could also just update the secrets so the old are revoked, but again the secrets are still in the resulting static site so no improvement really.Also added allow access to tag v* for github-pages environment in repo settings.
Hardly an improvement, but fun to learn a bit.
Type of change
Additional information
Checklist