frdedynamics / find_the_duck

🐤 A social game. Have you found the duck? Write your name and hide it again for the next person!
https://frdedynamics.github.io/find_the_duck/
ISC License
1 stars 1 forks source link

Remove secrets from repo but still in plain sight in deployed static site, and replace deploy workflow with less third party #17

Closed MOJOliciousFTW closed 9 hours ago

MOJOliciousFTW commented 2 days ago

GitHub Copilot Summary

This pull request focuses on restructuring the GitHub Actions workflows for deploying a Jekyll site and removing sensitive information from configuration files. The most important changes include replacing the existing deploy workflow with a new one, removing hardcoded secrets, and cleaning up configuration files.

Changes to GitHub Actions workflows:

Configuration cleanup:

Proposed change

Replace deploy workflow with less third party deps.

use only _config.yml and only with secrets. This is only a minor improvement, if any, the secrets are still found on the resulting static site. Secrets are not removed from commit history, that would require cleaning, could also just update the secrets so the old are revoked, but again the secrets are still in the resulting static site so no improvement really.

Also added allow access to tag v* for github-pages environment in repo settings.

Hardly an improvement, but fun to learn a bit.

Type of change

Additional information

Checklist