search

fre5h / DoctrineEnumBundle

📦 Provides support of ENUM type for Doctrine in Symfony applications.
https://github.com/fre5h/DoctrineEnumBundle
MIT License
460 stars 75 forks source link

Support for Symfony 6.0 #206

Closed fre5h closed 2 years ago

lsv commented 2 years ago

composer.json should properly be

"require": {
  ...
   "symfony/config": "^5.4|^6.0",
   "symfony/dependency-injection": "^5.4|^6.0",
   "symfony/doctrine-bridge": "^5.4|^6.0",
   "symfony/framework-bundle": "^5.4|^6.0",
   "symfony/http-kernel": "^5.4|^6.0",
   "symfony/validator": "^5.4|^6.0",
 ...
}
fre5h commented 2 years ago

@lsv Only if bundle uses Symfony API/config which is same in 5.4 and 6.0 As you know, in 6.0 were removed a lot of deprecations, so interfaces could be different. But I will consider this update, if no conflict, I will change it

lsv commented 2 years ago

It was actually just so you didnt need to have a new branch for symfony ^6.0 - but could use the same branch for ^5.4 and ^6.0.

And yes, if you dont use any deprecated things (which I dont see you do :) - then it should be pretty fine.

codecov[bot] commented 2 years ago

Codecov Report

Merging #206 (b6efa1e) into main (09f358d) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #206   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       113       113           
===========================================
  Files             12        12           
  Lines            267       267           
===========================================
  Hits             267       267
Impacted Files Coverage Δ
Command/EnumDropCommentCommand.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09f358d...b6efa1e. Read the comment docs.