freakdesign / shopify-custom-fields

A javascript tool to emulate Custom Fields within the Shopify dashboard.
http://freakdesign.com.au/pages/shopify-custom-fields
132 stars 24 forks source link

Empty Value Should Wipe Exisiting Value #37

Open chryton opened 7 years ago

chryton commented 7 years ago

Been noticing that if I need to turn something "off" by removing a value from a field (such as making a text input empty) that does not save or remove the metafield.

The only way to do this would be to go into FD and remove the generated metafield.

This is overall slightly confusing user experience as why should a user have to use another too to just reset/remove a value from a field and leave that field blank?

freakdesign commented 7 years ago

Thanks for the heads up.

I always thought that blanking the field did remove it, but it's possible that's all a dream. I wasn't planning on adding many more mods to this version, but this seems like a valid thing to add now.

chryton commented 7 years ago

@freakdesign Just checking in to see if this has been investigated at all. Still running into the issue on stores.

If there was unminified/source code, I or someone on my team could help debug the issue and submit a PR.

freakdesign commented 7 years ago

I tested this (briefly) and didn't see the same result. I followed these steps:

I'd be curious to see if you still see this problem and what steps you take.

chryton commented 7 years ago

Here is a screencast of what I am seeing on a test store: http://i.rocktc.de/tYAJET/31XiRHn2

freakdesign commented 7 years ago

That's most curious. I don't get the same result at all. Let's take a quick peek at your network logs and see what actions are actually firing. In your video there should be a metafield delete call being made. If not, or if it returns some error - that will help give me some starting clues to replicate.