search

freakdesign / shopifyFD

JavaScript layer to provide additional functionality and fixes to the Shopify dashboard
MIT License
223 stars 49 forks source link

Loading Functionality on Collection Pages Not Working #86

Open bradstemke opened 6 years ago

bradstemke commented 6 years ago

Functionality is loading on Product pages in the dashboard, and seemingly everywhere else, but on Collection pages within the Shopify Dashboard, for some reason they will not load. I get this error, and a popup that says "Error: Shopify Object not found."

Any insight would be super helpful! I checked the existing issues, and did not see this one, hope it is not a repeat.

I tried removing the extension and reinstalling, just for the heck of it, but that did not help.

It sometimes does show the "loaded" message at the bottom, but the widget area does not get added to the page.

If this is a weird thing with Shopify or something unrelated to app, then my bad! But thought I would bring it up incase someone else was having this issue. If a investigate and find the solution or a weird error on Shopify's end, I will report back.

Using Chrome on a Macbook Pro Version 69.0.3497.100 (Official Build) (64-bit)

screenshot 2018-10-02 12 10 50

dseif commented 6 years ago

I'm also hitting this.

I hit either of the following two cases:

a) The classList issue mentioned above. This appears to be because the script can't find the element with an id of content b) The Shopify global isn't attached to the window

screen shot 2018-10-11 at 3 33 30 pm

I'm also on OSX Chrome 69

rickydazla commented 6 years ago

Same here, also similar issues w/ Custom Fields, per https://github.com/freakdesign/shopify-custom-fields/issues/53

teezecrost commented 6 years ago

Same, but only on one of our sites!

dseif commented 6 years ago

Same, but only on one of our sites!

Yup, also the same deal with us.

dseif commented 6 years ago

I did some digging into this and it looks like this is all getting messed up due to most classes/id's being obfuscated now by Shopify. In addition to this, the Error: Shopify Object not found. can be avoided by loading the main collection page first then navigating to the specific collection. On a page refresh while on a specific collection page it seems like the Shopify global is never loaded. This appears to be because the admin/index script doesn't load unless you navigate from the admin/collections page.

Like @teezecrost mentioned, this only happens on one of our test sites (the others work fine). I wonder if there was an update/beta version of some changes that are only being rolled out to a sub-section of Shopify clients thats potentially causing this?

I'll keep investigating and see if I can figure out anything else.

teezecrost commented 6 years ago

Nice work, @dseif -thanks for unearthing some details!

freakdesign commented 6 years ago

No need for people to dig too much into this. It's known, and will be something that's expected to hit the other pages as well as the React admin rolls out everywhere.

We're at that point where I'm thinking it's time that a line is drawn in the current dev state, and I move over to the new one. I'll give things a proper review and weigh up all the issues to get a sense for pain either way.

I wonder if there was an update/beta version of some changes that are only being rolled out to a sub-section of Shopify clients thats potentially causing this?

Yep. Admin changes happen all the time. Some are small, some are big. The move to react is a biggie so has much bigger potential to hurt hacky projects like this.

ShopifyFD will be sorted, but use your plan B's in the meantime.

rickydazla commented 6 years ago

"The move to react is a biggie so has much bigger potential to hurt hacky projects like this."

Truly one of the best Shopify hacks there is

tjmapes commented 6 years ago

@dseif

... the Error: Shopify Object not found. can be avoided by loading the main collection page first then navigating to the specific collection.

So, nice find, but I'm not following. I need to hit site.myshopify.com/admin/collections then search for the collection I want, then click on it, then load it up?

alanhouser commented 6 years ago

Agree with @tjmapes — maybe the finding was not a fix found, but an issue that's contributing to the issues. I hope we have a PLAN B, because this hack is great. (and we launch in 5 hours! HAHA)

dseif commented 6 years ago

Right - from my earlier comment, there are two potential issues at play.

One is the Shopify object not found, which has a workaround it seems. The other (the classList issue in the console), I haven't figured out a workaround for yet.

Are you guys seeing the classList issue as well?