Set lines for "Allowed Roles" in pv-inverter to active

freakent / dbus-mqtt-devices

A driver for Victron VenusOS GX devices to support use of dbus-mqtt/flashmq-mqtt

MIT License

111 stars 24 forks source link

Set lines for "Allowed Roles" in pv-inverter to active #28

Closed stromibaer closed 9 months ago

stromibaer commented 1 year ago

Hello, as written in https://github.com/freakent/dbus-mqtt-devices/issues/23 the PR activates the "allowed roles" lines for the pv-inverter to change it's position between AC-IN and AC-OUT:

This is necessary for easier integration of Hoymiles inverters to push there values with the dbus-mqqt-devices driver automatically from Open-DTU to VRM portal. See also PR https://github.com/tbnobody/OpenDTU/pull/377

Thanks, Peter

freakent commented 1 year ago

Hi Peter, my apologies for not seeing your pull request earlier. I'll review and merge asap if all looks OK.

jeroenkl commented 9 months ago

Hi Peter, my apologies for not seeing your pull request earlier. I'll review and merge asap if all looks OK.

is it possible ti have it merged?

freakent commented 9 months ago

The changes proposed in this PR have already been reflected in the new beta release. Generally I am not comfortable merging changes that I have no tests for. However since you have verified the changes proposed in the PR I have rolled this into the main branch.