search

freakent / dbus-mqtt-devices

A driver for Victron VenusOS GX devices to support use of dbus-mqtt/flashmq-mqtt
MIT License
101 stars 22 forks source link

setup.sh shoiuld check if there are existing entries in /data/rc.local #90

Closed freakent closed 4 months ago

freakent commented 5 months ago

Version

0.6.4 (current)

What version of VenusOS are you running on your GX device

3.20 (current release)

Does this issue occur during installation or at runtime ?

Installation

Is there a Discussion thread for this issue? Please paste a link.

https://github.com/freakent/dbus-mqtt-devices/discussions/85#discussioncomment-8490303

What is the issue you are actually experiencing?

When installing a new version you end up with multiple entries in the /data/rc.local file. Setup.sh should either warn the user or diable the existing entry. Currently users have to tske the time to find the Troubleshooting section in the readme which is suboptimal.

What does the status payload look like that you are publishing to the driver to register your device?

No response

Relevant log output

No response

freakent commented 4 months ago

Initially thought it would be easier to update the README with some instructions but after a little investigation fugured out an awk script that could comment out any unwanted lines.

freakent commented 4 months ago

Fixed in v0.6.5