search

freakent / node-red-contrib-sunevents

A node for node-red that generates events based on the position of the Sun at the appropriate time of day.
Apache License 2.0
15 stars 13 forks source link

Make node description internet independent #29

Closed Shaquu closed 1 year ago

Shaquu commented 2 years ago

Hi, during my internet outage I have noticed that node is using Internet to fetch some images for sun-events-node. I am pretty sure it would be better to move those images to dist pack and fetch images offline.

    <p>Example 1: Fixed GPS position (<a href="https://raw.githubusercontent.com/freakent/node-red-contrib-sunevents/main/examples/sun-events-example-flows.json" target="_blank">Download</a>)
    <img src="https://raw.githubusercontent.com/freakent/node-red-contrib-sunevents/main/docs/flow-diagram-1.png">

    <p>Example 2: Stream of GPS positions (<a href="https://raw.githubusercontent.com/freakent/node-red-contrib-sunevents/main/examples/sun-events-gps-stream-example-flows.json" target="_blank">Download</a>)
    <img src="https://raw.githubusercontent.com/freakent/node-red-contrib-sunevents/main/docs/flow-diagram-2.png">
freakent commented 2 years ago

Nice idea. Send me a pull request and I’ll review.

On 8 Oct 2021, at 20:32, Tadeusz Wyrzykowski @.***> wrote:

 Hi, during my internet outage I have noticed that node is using Internet to fetch some images for sun-events-node. I am pretty sure it would be better to move those images to build pack and fetch images offline.

<p>Example 1: Fixed GPS position (<a href="https://raw.githubusercontent.com/freakent/node-red-contrib-sunevents/main/examples/sun-events-example-flows.json" target="_blank">Download</a>)
<img src="https://raw.githubusercontent.com/freakent/node-red-contrib-sunevents/main/docs/flow-diagram-1.png">

<p>Example 2: Stream of GPS positions (<a href="https://raw.githubusercontent.com/freakent/node-red-contrib-sunevents/main/examples/sun-events-gps-stream-example-flows.json" target="_blank">Download</a>)
<img src="https://raw.githubusercontent.com/freakent/node-red-contrib-sunevents/main/docs/flow-diagram-2.png">

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/freakent/node-red-contrib-sunevents/issues/29", "url": "https://github.com/freakent/node-red-contrib-sunevents/issues/29", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]