Check polyphon pattern search

freakimkaefig / Music-XML-Analyzer

Music XML Analyzer

MIT License

15 stars 4 forks source link

Closed freakimkaefig closed 9 years ago

freakimkaefig commented 9 years ago

Only base note is searched??? notes with <chord/>-Tag ignored??

freakimkaefig commented 9 years ago

Result for search (sound sequence) d/4 d/4 in ActorPreludeSample.xml
unbenannt

led13714 commented 9 years ago

yes is ignored in soundsequence-, melody- and rhythm-search. -> change?

freakimkaefig commented 9 years ago

ask manuel.burghardt@ur.de

led13714 commented 9 years ago

well they have been removed for a good reason, see #95 and #99. short version:

not possible to search for chords at the moment
enabling chord notes leads to less results (no chord tag in pattern search vs chord tag in xml files)

--> only base notes are searched, which means sound sequences within chords are ignored

*\ add note/hint about that somewhere?

matTailor commented 9 years ago

Maybe we could add a hint to get the users informed about not being able to search for chords

semmler1988 commented 9 years ago

note/hint sounds like a good idea

led13714 commented 9 years ago

added a hint on the results page (e0079aa41e9ef331e9babf6e268316fc32e208b6)

is that the way to go?

freakimkaefig commented 9 years ago

For now!