Code cleaning

[freakimkaefig]

ggf methoden ordentlich kommentieren:

Javascript

/**
 * Method description
 *
 * @param {datatype}    name    description
 *
 * @return {datatype}    name    description
 */
bla123 = function(name) { ... }

http://en.wikipedia.org/wiki/JSDoc

---

PHP

/**
 * Helper function to calculate the starting measures number
 *
 * @param   \DOMNode    $part     The \DOMNode element for the music xml part
 * @param   int         $start   The start notes number (inside the part)
 *
 * @return  int         Number of the measure where the extract should start
 *
 */
private function calculateStartExtract($part, $start) { ... }

http://de.wikipedia.org/wiki/PHPDoc http://www.phpdoc.org/docs/latest/index.html

[led13714]

• [x] remove trailing whitespaces
• [x] remove unnessesary comments & logging
• [x] replace '!=' with '!==' if type comparission is needed (pretty much every where...)
  • [x] unnötig kompliziert jetz jedes mal nachzuschaun ob wert&type abgleich angebracht ist, da oftmals unklar ob z.B. boolesche werte tatsächlich vorliegen, oder ob true/false als String gesetzt....
• [x] einrückungen

[led13714]

• [x] @ luggi: Result.php
• [x] @ luggi: Upload.php
• [x] @ luggi: User.php
• [x] @ luggi: UploadController.php
• [x] @ luggi: HeaderView.js
• [x] @ luggi: finish/correct ResultView.js
• [x] @ luggi: finish/correct UploadView.js

[matTailor]

@luggi: am besten kommentierst du no die methoden beim dashboard model. Denke des kannst du besser erklären weistas ja a gmacht hast ;)

[matTailor]

patternModel & resultModel cleaned!

[led13714]

• [x] DashboardModel.js
• [x] UploadController.js