Add log messages produced during crash report generation to minidump files

GoogleCodeExporter commented 8 years ago

We always planned for log messages produced during crash report generation to 
make it into the minidump file. This would provide insight into things 
Crashpad’s not able to see, and could help catch bugs in Crashpad or improve 
the robustness of its snapshotting code.

This can be implemented with a log message handler 
(logging::SetLogMessageHandler()) which can be brought into mini_chromium’s 
logging.h.

The log message handler used in crashpad_handler should collect log messages 
from the thread in crashpad_handler that’s taking the snapshot. These 
messages can be added to the minidump in a string list reachable from 
MinidumpCrashpadInfo.

Original issue reported on code.google.com by mark@chromium.org on 27 Mar 2015 at 3:17

GoogleCodeExporter commented 8 years ago

Add logging::SetLogMessageHandler() to mini_chromium: 
https://codereview.chromium.org/1033323002

Original comment by mark@chromium.org on 27 Mar 2015 at 5:29

Changed state: Started

GoogleCodeExporter commented 8 years ago

https://codereview.chromium.org/1041643003/ Add ThreadLogMessages and its test

has the following mini_chromium dependencies:

https://codereview.chromium.org/1033323002/ Add logging::SetLogMessageHandler()
https://codereview.chromium.org/1039143004/ Add base::ThreadLocalStorage
https://codereview.chromium.org/1039823002/ Add base::LazyInstance
https://codereview.chromium.org/1038423003/ Fix base/memory/aligned_memory.h 
for MSVC
https://codereview.chromium.org/1042353002/ base/logging.h: DCHECK() should 
always reference its condition

Original comment by mark@chromium.org on 30 Mar 2015 at 4:44

freaking1 / crashpad

Add log messages produced during crash report generation to minidump files #26