freaktechnik / advanced-github-notifier

A Firefox extension, that not only shows a count of notifications, but also shows notification popups and has a popup that gives direct access to the notifications.
https://addons.mozilla.org/addon/advanced-github-notifier/?utm_source=github&utm_content=about
Mozilla Public License 2.0
80 stars 5 forks source link

Better the main icon #366

Open andry81 opened 2 years ago

andry81 commented 2 years ago

Describe the bug If switch to GitHub dark page color mode, then icon becomes barely visible. The same for the Firefox about:addons page.

Example:

To Reproduce Steps to reproduce the behavior:

  1. Switch GitHub/Firefox to dark page color mode.

Expected behavior Another older extension has an example of a better icon: https://github.com/sindresorhus/notifier-for-github

Example:

Firefox (please complete the following information):

freaktechnik commented 2 years ago

The toolbar button should be switching to a light version for themes that declare themselves as dark (https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/github-light.svg).

andry81 commented 2 years ago

The toolbar button should be switching to a light version for themes that declare themselves as dark (https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/github-light.svg).

This is not the application icon.

tooomm commented 2 years ago

@freaktechnik He is talking about https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/icon.svg

add-on page

The dark blue plus sign of that icon is also not easy to distinguish from the black bell as well.

andry81 commented 2 years ago

The dark blue plus sign of that icon is also not easy to distinguish from the black bell as well.

It's not easy distinguish from the dark background either.