search

freaktechnik / justintv-stream-notifications

This Firefox add-on displays a notification when a channel on Twitch, Youtube, Mixer or many more services goes live. Which channels are checked for being live is fully customizable.
https://freaktechnik.github.io/justintv-stream-notifications
Other
38 stars 10 forks source link

Logins aren't correctly migrated to IDs for Twitch #457

Closed Valdaria closed 5 years ago

Valdaria commented 5 years ago

When the extension updated to the v3.10.1 it asked me the new permission, I clicked on Yes. And I don't have access to the Live channels, on click to the refresh button, it does nothing. Even when i remove my user and re-add it, and restart Firefox too didn't help

System Info

Debug Dump

Please go to the channels manager and Shift + Click on the "Help" button. Paste the result as a replacement of these instructions between the "```". Leave the "json" at the beginning as-is.

This is not working sorry
freaktechnik commented 5 years ago

Thank you for reporting this.

Could you alternatively at least attach an export from the options in a comment, so I can see what channels, users and settings you're using?

Further, it would be really nice if you could check out about:debugging, enable debugging and click "Debug" for the extension's entry. This should open a window with a couple of tabs, one of them is "Network". You should see the extension making requests to the respective API to check on the status for your channels in the update period you have configured (60 seconds by default).

The "Console" tab should show errors and warnings happening (sadly not only with the extension but also some unrelated warnings and errors from Firefox). A screenshot of that may be very useful.

Valdaria commented 5 years ago

When I reload the extension, it produce the flowing request https://api.twitch.tv/helix/users?first=100&login=kyriog&login=modiiie&login=mythixtrinity&login=alsacedigitale&login=krayn_live&login=gamekultlive&login=gamesdonequick&login=octobinz&login=adunbeex&login=drekher&login=at0mium&login=aureliensama&login=iveinsomnia&login=eliseegw&login=mistermv&login=merry&login=epeeforteyt&login=iryusa&login=hug0delire36&login=aypierre&login=wankilstudio&login=unexpected&login=metalchewie&login=123lunatic&login=luoren&login=ubisoftfr&login=zerator&login=mrelvilia&login=metalchewbacca&login=sparklinlabs&login=frozencrystal&login=chucklefishlive&login=ubisoft&login=mrhelmut&login=dandrumstone&login=shoukaseikyo&login=developpeusedudimanche&login=sezzadactyl&login=benprunty&login=ngon&login=trinity&login=elspeth&login=gius&login=mizu&login=maghla&login=aayley&login=moman&login=ldlc&login=streambox&login=valdaria Which return me the list of the listed users as expected. Response from twitch API

But when it searches for live channels it produces some requests with a 404 response. https://tmi.twitch.tv/hosts?host=kyriog,modiiie,mythixtrinity,alsacedigitale,krayn_live,gamekultlive,gamesdonequick,octobinz,adunbeex,drekher,at0mium,aureliensama,iveinsomnia,eliseegw,mistermv,merry,epeeforteyt,iryusa,hug0delire36,aypierre,wankilstudio,unexpected,metalchewie,123lunatic,luoren,ubisoftfr,zerator,mrelvilia,metalchewbacca,sparklinlabs,frozencrystal,chucklefishlive,ubisoft,mrhelmut,dandrumstone,shoukaseikyo,developpeusedudimanche,sezzadactyl,benprunty,ngon,trinity,elspeth,gius,mizu,maghla,aayley,moman,ldlc,streambox,274708447,172003727,18887776,131215608,71356558,90057039,63532168,176569404,51939660,89950696,135834349,36305404,97443047,74093730,2158531,44741547,39456099,48759454,40383341,192971152,55434616,29166361,22510310,56269580,140224905,32532553,24306397,28119552,24815334,28575692,71287551,38995750,26529407,52803405,29753247,31289086,132214257,146892381,89205505,53152449,55081823,41719107,23217261,89807174,117640446,56404255

Console output The extension options are the defaults options

freaktechnik commented 5 years ago

Thank you for that. The export from the options also includes all channels and users and gives me a hint about how they are stored in the database. This would still be helpful, especially since that host request (the second one) looks very wrong.

Alternatively, is there a single user I can add that reliably breaks it for you?

Valdaria commented 5 years ago

You can add my user "Valdaria", it contains all the channels listed above

Valdaria commented 5 years ago

The exported options 

{
    "channels": [
        {
            "login": "117640446",
            "type": "twitch"
        },
        {
            "login": "123lunatic",
            "type": "twitch"
        },
        {
            "login": "131215608",
            "type": "twitch"
        },
        {
            "login": "132214257",
            "type": "twitch"
        },
        {
            "login": "135834349",
            "type": "twitch"
        },
        {
            "login": "140224905",
            "type": "twitch"
        },
        {
            "login": "146892381",
            "type": "twitch"
        },
        {
            "login": "172003727",
            "type": "twitch"
        },
        {
            "login": "176569404",
            "type": "twitch"
        },
        {
            "login": "18887776",
            "type": "twitch"
        },
        {
            "login": "192971152",
            "type": "twitch"
        },
        {
            "login": "2158531",
            "type": "twitch"
        },
        {
            "login": "22510310",
            "type": "twitch"
        },
        {
            "login": "23217261",
            "type": "twitch"
        },
        {
            "login": "24306397",
            "type": "twitch"
        },
        {
            "login": "24815334",
            "type": "twitch"
        },
        {
            "login": "26529407",
            "type": "twitch"
        },
        {
            "login": "27249477",
            "type": "twitch"
        },
        {
            "login": "274708447",
            "type": "twitch"
        },
        {
            "login": "28119552",
            "type": "twitch"
        },
        {
            "login": "28575692",
            "type": "twitch"
        },
        {
            "login": "29166361",
            "type": "twitch"
        },
        {
            "login": "29753247",
            "type": "twitch"
        },
        {
            "login": "31289086",
            "type": "twitch"
        },
        {
            "login": "32532553",
            "type": "twitch"
        },
        {
            "login": "36305404",
            "type": "twitch"
        },
        {
            "login": "38995750",
            "type": "twitch"
        },
        {
            "login": "39456099",
            "type": "twitch"
        },
        {
            "login": "40383341",
            "type": "twitch"
        },
        {
            "login": "41719107",
            "type": "twitch"
        },
        {
            "login": "44741547",
            "type": "twitch"
        },
        {
            "login": "48759454",
            "type": "twitch"
        },
        {
            "login": "51939660",
            "type": "twitch"
        },
        {
            "login": "52803405",
            "type": "twitch"
        },
        {
            "login": "53152449",
            "type": "twitch"
        },
        {
            "login": "55081823",
            "type": "twitch"
        },
        {
            "login": "55434616",
            "type": "twitch"
        },
        {
            "login": "56269580",
            "type": "twitch"
        },
        {
            "login": "56404255",
            "type": "twitch"
        },
        {
            "login": "63532168",
            "type": "twitch"
        },
        {
            "login": "71287551",
            "type": "twitch"
        },
        {
            "login": "71356558",
            "type": "twitch"
        },
        {
            "login": "74093730",
            "type": "twitch"
        },
        {
            "login": "75373669",
            "type": "twitch"
        },
        {
            "login": "89205505",
            "type": "twitch"
        },
        {
            "login": "89807174",
            "type": "twitch"
        },
        {
            "login": "89950696",
            "type": "twitch"
        },
        {
            "login": "90057039",
            "type": "twitch"
        },
        {
            "login": "97443047",
            "type": "twitch"
        },
        {
            "login": "aayley",
            "type": "twitch"
        },
        {
            "login": "adunbeex",
            "type": "twitch"
        },
        {
            "login": "alsacedigitale",
            "type": "twitch"
        },
        {
            "login": "at0mium",
            "type": "twitch"
        },
        {
            "login": "aureliensama",
            "type": "twitch"
        },
        {
            "login": "aypierre",
            "type": "twitch"
        },
        {
            "login": "benprunty",
            "type": "twitch"
        },
        {
            "login": "chucklefishlive",
            "type": "twitch"
        },
        {
            "login": "dandrumstone",
            "type": "twitch"
        },
        {
            "login": "developpeusedudimanche",
            "type": "twitch"
        },
        {
            "login": "drekher",
            "type": "twitch"
        },
        {
            "login": "eliseegw",
            "type": "twitch"
        },
        {
            "login": "elspeth",
            "type": "twitch"
        },
        {
            "login": "epeeforteyt",
            "type": "twitch"
        },
        {
            "login": "frozencrystal",
            "type": "twitch"
        },
        {
            "login": "gamekultlive",
            "type": "twitch"
        },
        {
            "login": "gamesdonequick",
            "type": "twitch"
        },
        {
            "login": "gius",
            "type": "twitch"
        },
        {
            "login": "hug0delire36",
            "type": "twitch"
        },
        {
            "login": "iryusa",
            "type": "twitch"
        },
        {
            "login": "iveinsomnia",
            "type": "twitch"
        },
        {
            "login": "krayn_live",
            "type": "twitch"
        },
        {
            "login": "kyriog",
            "type": "twitch"
        },
        {
            "login": "ldlc",
            "type": "twitch"
        },
        {
            "login": "luoren",
            "type": "twitch"
        },
        {
            "login": "maghla",
            "type": "twitch"
        },
        {
            "login": "merry",
            "type": "twitch"
        },
        {
            "login": "metalchewbacca",
            "type": "twitch"
        },
        {
            "login": "metalchewie",
            "type": "twitch"
        },
        {
            "login": "mistermv",
            "type": "twitch"
        },
        {
            "login": "mizu",
            "type": "twitch"
        },
        {
            "login": "modiiie",
            "type": "twitch"
        },
        {
            "login": "moman",
            "type": "twitch"
        },
        {
            "login": "mrelvilia",
            "type": "twitch"
        },
        {
            "login": "mrhelmut",
            "type": "twitch"
        },
        {
            "login": "mythixtrinity",
            "type": "twitch"
        },
        {
            "login": "ngon",
            "type": "twitch"
        },
        {
            "login": "octobinz",
            "type": "twitch"
        },
        {
            "login": "sezzadactyl",
            "type": "twitch"
        },
        {
            "login": "shoukaseikyo",
            "type": "twitch"
        },
        {
            "login": "sparklinlabs",
            "type": "twitch"
        },
        {
            "login": "streambox",
            "type": "twitch"
        },
        {
            "login": "trinity",
            "type": "twitch"
        },
        {
            "login": "ubisoft",
            "type": "twitch"
        },
        {
            "login": "ubisoftfr",
            "type": "twitch"
        },
        {
            "login": "unexpected",
            "type": "twitch"
        },
        {
            "login": "wankilstudio",
            "type": "twitch"
        },
        {
            "login": "zerator",
            "type": "twitch"
        }
    ],
    "users": [
        {
            "login": "122274651",
            "type": "twitch"
        }
    ],
    "prefs": {
        "updateInterval": 60,
        "onlineNotification": true,
        "titleChangeNotification": true,
        "offlineNotification": false,
        "nonliveNotification": false,
        "panel_style": "1",
        "panel_nonlive": "0",
        "panel_sort_field": "uname",
        "panel_sort_direction": "0",
        "panel_extras": false,
        "panel_badges": false,
        "panel_badge": false,
        "theme": "0",
        "copy_pattern": "{URL}",
        "updateTab": true,
        "queue_concurrentRequests": 4,
        "twitch_clientId": "1owsrolvxz8khldqe6puadzd8bldq34",
        "twitch_showHosting": true,
        "youtube_apiKey": "AIzaSyD24JzaWYvPlnhvGbuNIv1J5ueNgd59EPM",
        "mlg_showRebroadcasts": true,
        "channellist_cacheTime": 600000,
        "queueservice_maxRetries": 5,
        "find_mature": true,
        "rebroadcast_title_pattern": "rerun,rediff,rebroadcast,replay,recap,re-run,re-diff,re-play,re-cap,re-broadcast",
        "show_mature_thumbs": true,
        "click_action": "0",
        "mixer_clientID": "773cc80c2739ca0c26298fccc800a8a181be5f58d1682e3b"
    }
}
freaktechnik commented 5 years ago

Adding the user "Valdaria" works fine for me in a clean install, so the TMI request looks like this: https://tmi.twitch.tv/hosts?host=274708447,172003727,18887776,131215608,71356558,90057039,63532168,176569404,51939660,89950696,135834349,36305404,97443047,74093730,2158531,44741547,39456099,48759454,40383341,192971152,55434616,29166361,22510310,56269580,140224905,32532553,24306397,28119552,24815334,28575692,71287551,38995750,26529407,52803405,29753247,31289086,132214257,146892381,89205505,53152449,55081823,41719107,23217261,89807174,117640446,56404255. I'll try upgrading with that user added myself, maybe I can reproduce the duplication issue you seem to have.

Thank you for the export. As you can see there, some of the channels have a number as a login and some have a username. They should all have a number. And I'm pretty sure they're actually duplicates of each other.

Valdaria commented 5 years ago

Fresh install of the extension worked. Also, all the channels in the "Offline tab" were duplicated

Thank you for your help

freaktechnik commented 5 years ago

Sorry for the issue with the migration, I'll still try to fix this automatically for other users that may not have as easy a time of re-adding all their things!

freaktechnik commented 5 years ago

I think 3.10.3 should've landed all the parts necessary to let the extension heal a failed migration. Closing here. Please comment (or reopen, if you can) if your updating cycle is still broken with 3.10.3.