freckle / bcp47

BCP-47 for Haskell
https://freckle.github.io/bcp47/
2 stars 1 forks source link

Fix `Trie2` `Semigroup` instance #29

Closed mjgpy3 closed 2 years ago

mjgpy3 commented 2 years ago

How?

The instance was using <> to combine values at the top level but <|> at lower levels. This uses <> at all levels.

Please Advise

On how to version this. Could break code that's out there, won't break compilation.

mjgpy3 commented 2 years ago

Looks like this is a PATCH version update per our guides

Bug fixes that don't effect the API happen in PATCH

(EPOCH.MAJOR.MINOR.PATCH)