add an orphan for the BCP47 Serialise instance

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.03 :warning:

Comparison is base (6b3c54a) 88.13% compared to head (e5764c9) 88.11%.

:exclamation: Current head e5764c9 differs from pull request most recent head 66b9342. Consider uploading reports for the commit 66b9342 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== - Coverage 88.13% 88.11% -0.03% ========================================== Files 17 18 +1 Lines 236 244 +8 Branches 1 1 ========================================== + Hits 208 215 +7 - Misses 28 29 +1 ``` | [Impacted Files](https://app.codecov.io/gh/freckle/bcp47/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=freckle) | Coverage Δ | | |---|---|---| | [bcp47-orphans/library/Data/BCP47/Serialise.hs](https://app.codecov.io/gh/freckle/bcp47/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=freckle#diff-YmNwNDctb3JwaGFucy9saWJyYXJ5L0RhdGEvQkNQNDcvU2VyaWFsaXNlLmhz) | `87.50% <87.50%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tomcarste commented 1 year ago

@pbrisbin as I said in slack, I don't fully know how to solve some of the yaml file errors. They're complaining about wrong versions of ghc. I never really mastered stack, it's always been an adhoc skill since I never really had much need of it. So if you have pointers on figuring it out I'd appreciate them.

pbrisbin commented 1 year ago

as I said in slack, I don't fully know how to solve some of the yaml file errors

I saw you ask how to generate checksums, and I replied you don't need to. I didn't see anything else.

Looking at the CI errors now, this seems unrelated to your work. I can take a look.

pbrisbin commented 1 year ago

OK, I fixed up CI in #37. Please rebase. At that point, the only failures sure be directly caused by your change and we can go from there.

To reproduce a CI failure you just have to pass the --stack-yaml that that Job is using. For example, if you find lts-12.26 is failing on CI:

stack --stack-yaml stack-lts-12.26.yaml build ... --file-watch

Then you can iterate on extra-deps as necessary locally.

tomcarste commented 1 year ago

@pbrisbin lts-12.26 doesn't work on arm macs.


% stack --stack-yaml stack-lts-12.26.yaml build
Error: [S-9443]
No setup information found for ghc-8.4.4 on your platform.
This probably means a GHC bindist has not yet been added for OS key 'macosx-aarch64'.
Supported versions: ghc-8.10.5, ghc-8.10.6, ghc-8.10.7, ghc-9.0.2, ghc-9.2.1, ghc-9.2.2, ghc-9.2.3, ghc-9.2.4, ghc-9.2.5, ghc-9.2.6, ghc-9.2.7, ghc-9.2.8, ghc-9.4.1, ghc-9.4.2, ghc-9.4.3, ghc-9.4.4, ghc-9.4.5, ghc-9.6.1, ghc-9.6.2```

freckle / bcp47

add an orphan for the BCP47 Serialise instance #35

Codecov Report