search

freckle / bcp47

BCP-47 for Haskell
https://freckle.github.io/bcp47/
2 stars 1 forks source link

Add bcp47-orphans package with persistent and cassava instances #4

Closed cdparks closed 5 years ago

cdparks commented 5 years ago

We can do this without the separate packages if you like, but I didn't know if you wanted to depend on cassava and persistent in the core library. This might be easier to read in the individual commits, but broad stroaks:

  1. Moved existing library into bcp47 subdirectory
  2. Lifted toText implementation out of Show instance and exported it
  3. Made specifier parsers ensure they never finished parsing inside a token (this was causing the roundtrip failures)
  4. Added ToField and FromField instances in bcp47-cassava package
  5. Added PersistField instance in bcp47-persistent package
cdparks commented 5 years ago

or go hard the other way and open source a separate repo

I think this is outside of our private repo because it's intended to be uploaded to Hackage eventually.

cdparks commented 5 years ago

Talked offline and decided to have a single bcp47-orphans package