Set up CI - Githubissues

pbrisbin commented 5 years ago

Must have:

Circle for current LTS

Nice to have:

Circle for supported GHCs via alternate LTSs
Code Climate
Hackage publish in master CI
Restyled

https://github.com/freckle/faktory_worker_haskell is another of our OSS packages that is slightly more mature in this area and can be used as reference.

eborden commented 5 years ago

Circle has been setup. Code Climate and Restyled still need to be added as authorized apps. I for the life of me can't find where to do that.

pbrisbin commented 5 years ago

Nice! Code Climate and Restyled should be org-level authorized, which may be why you can't find any settings (if you're looking in Repo-level pages). Adding open source repos in Code Climate is notoriously bad UX, so I can go figure that out. I'd expect Restyled to Just Work, so I'll also look into that :)

pbrisbin commented 5 years ago

Added Code Climate. https://codeclimate.com/github/freckle/bcp47. I also enabled HLint and ShellCheck via the UI (rather than a codeclimate.yaml). Never done this before, so we'll see how it goes.

For the record, here were the steps:

Go to CC
Make sure you're in your Open Source "org"
Add repository
Go to Settings to install PR and Webhook (may not be needed, but I did it anyway)

For Restyled, I must have had permissions to first install it, and I chose to limit it to megarepo, but I don't currently have permissions to get back to those settings and open it up for additional repos. We need @AKurilin:

Alex, can you look into the Org settings for Freckle, and modify the repo limitations on the Restyled GitHub App? This can be found by going into your personal GitHub settings, then Organization Settings in the sidebar, then click the Freckle org, and look for Repository Access:

Please add this repo to the list. (Though I would like to, I don't think we can open it up to all repos specifically because it would bother David on stratosphere PRs.)

eborden commented 5 years ago

Thanks @pbrisbin!

pbrisbin commented 5 years ago

Calling this closed, not sure if we just forgot to do so or are waiting for nice-to-haves. Either way, I think it's not valuable to leave this open.

freckle / bcp47

Set up CI #6