search

freckle / graphula

A simple interface for generating persistent data and linking its dependencies
MIT License
45 stars 11 forks source link

Support persistent-2.13 #61

Closed parsonsmatt closed 3 years ago

pbrisbin commented 3 years ago

I'll merge and release this today; thanks!

pbrisbin commented 3 years ago

@parsonsmatt did you want me to try and get the build Green, or can you do that? It looks like an unnecessary dependency, but I haven't dug in yet.

parsonsmatt commented 3 years ago

persistent-template-2.12 is a dummy package that has docs that tell you to just use persistent from 2.12 on. It doesn't export anything.

pbrisbin commented 3 years ago

So all the more reason to remove it from the dependencies and fix this error?

 <no location info>: error: [-Wunused-packages, -Werror=unused-packages]
    The following packages were specified via -package or -package-id flags,
    but were not needed for compilation:
      - persistent-template-2.12.0.0

Or am I missing something?

parsonsmatt commented 3 years ago

What's really annoying is that you'd want to conditionally depend on it. If persistent < 2.12, then you need persistent-template. But if persistent >= 2.12, then you don't need it. And IIRC cabal does not have a way to specify that.

pbrisbin commented 3 years ago

Sigh. And there's no way to disable -Wunused-packages except globally, is there?

pbrisbin commented 3 years ago

I just did a release that removed upper bounds (we've decided the maintenance burden is too much for us and are going to try being more lax for now) to unblock https://github.com/commercialhaskell/stackage/issues/6010.

I didn't add the extra-deps, so the -template issue wasn't triggered and CI was green. Sorry for the conflicts.

parsonsmatt commented 3 years ago

Thanks! That works for me 😄