Fixes discovered in lts-15.0 update

freckle / rcl

Stackage resolver changelog

MIT License

0 stars 0 forks source link

Fixes discovered in lts-15.0 update #4

Closed pbrisbin closed 4 years ago

pbrisbin commented 4 years ago

Handle base Changelog specially
- Use the GitHub URL
- Update Changelog "parsing" to target between new/old, not just seek from top to old
Don't error on missing Changelogs

This is not uncommon, so we shouldn't crash.
Look for linked version headers

Seems:

... [$version] ...

Is another common convention for Changelogs.
Handle CRLF content

And minor style changes.

pbrisbin commented 4 years ago

So, Restyled errors because apply-refact (called to auto-fix HLint errors) doesn't respect some syntactic extensions defined via default-extensions, specifically LambdaCase. I haven't decided the best way to handle this. In personal projects, I keep such extensions out of default-extensions and force myself to do it via LANGUAGE, which works, but ick. I'm not ready to push that solution on Freckle projects yet, so I'm going to just merge around Restyled here and defer the decision.

eborden commented 4 years ago

Agreed on your feeling for LANGUAGE pragmas. I prefer them in my side work, but haven't felt the need at Freckle.