search

freckle / stackctl

Manage CloudFormation Stacks through specifications
MIT License
14 stars 1 forks source link

Respect STACKCTL_DIRECTORY in findRemovedStack #71

Closed pbrisbin closed 5 months ago

pbrisbin commented 5 months ago

When inferring removed stacks, we use use the fact that a specification doesn't exist on disk to decide to remove the corresponding stack. Checking for the specification on disk was not using STACKCTL_DIRECTORY, so if one were set this would always report the file as missing and could result in deleting a stack we should not.

pbrisbin commented 5 months ago

Sorry I missed your other PR also bumping resolver and actions versions Chris, I can wait and remove/rebase that if you prefer.

chris-martin commented 5 months ago

Well, wait, are you going to edit the version and changelog here?

pbrisbin commented 5 months ago

Well, wait, are you going to edit the version and changelog here?

I can, or I don't have to. I hadn't decided yet. Does it change your answer?

chris-martin commented 5 months ago

I just didn't want to end up releasing your changes without a changelog entry by accident. But ultimately the answer is "I already merged because I forgot about this" :|