search

freckle / weeder-action

Run Weeder to uncover unused Haskell functions
MIT License
7 stars 0 forks source link

Version in Description #22

Open StevenXL opened 4 months ago

StevenXL commented 4 months ago

When the action runs, it outputs a version. The version that it outputs is the version of GHC that the action detected, not the version of weeder being used.

Is this intentional? I was expecting the version to be the version of weeder itself:

image

pbrisbin commented 1 month ago

It is expected, but I see how it's misleading.

Weeder must be built with the same version of GHC as the project you intend to run it on. This means that the same weeder version (say, 2.7.0) must be built multiple times with different GHCs (say 9.4.5 and 9.4.7). For this reason, the built binaries are named by GHC version (weeder-9.4.5 and weeder-9.4.7), not weeder version (which would be weeder-2.7.0 for both).

We could experiment with ways to clarify this. Maybe call them weeder-{weeder-version}-ghc{ghc-version}, so weeder-2.7.0-ghc9.4.5, or something. I don't know that it's worth it, but feel free to tackle.