search

fred-wang / webextension-native-mathml

18 stars 3 forks source link

katex: Ensure MathML actually displays #3

Closed auscompgeek closed 6 years ago

fred-wang commented 7 years ago

Thanks. Do you have a test case or explanation ?

(that does not seem necessary on https://khan.github.io/KaTeX/ )

auscompgeek commented 7 years ago

I use a website, specifically a LMS https://edstem.org, that has this rule:

.katex .katex-mathml {
    display: none;
}

Maybe we shouldn't have a !important on this though…

fred-wang commented 7 years ago

OK, I think it makes sense to have this rule then since the users of the add-on wants to see the MathML. Does this work without the !important ?

auscompgeek commented 6 years ago

Oops, sorry for leaving this thread dangling.

It seems to work without the !important, yes.

fred-wang commented 6 years ago

@auscompgeek Can you please update your PR to not use the "!important" then? Thanks!

auscompgeek commented 6 years ago

Sure. Do you think there should also be a comment explaining that this doesn't acutally override a rule provided by KaTeX's CSS, but rather some websites' own CSS rules?

fred-wang commented 6 years ago

Yes, I guess a comment could be useful

fred-wang commented 6 years ago

@auscompgeek Sorry, I missed your patch. Merging now. Thanks!