fredboudon / plantscan3d

An open-source GUI for reconstructing plant 3D architecture from laser scans.
Other
27 stars 11 forks source link

Error in Saving the Project and in Exporting angles #15

Open Micbut opened 1 year ago

Micbut commented 1 year ago

Hi, let me first tell you that this software is amazing and so its potential.

I managed to easily upload my point cloud and reconstruct the topology.

As mentioned in the guide, the software often crash and it is advised to save often, however, when I try to save it gives me error. The both the Save Project and the Open Project option are not selectable.

I am using windows 10 and I launch plantscan3d from an environment dedicated to openalea in anaconda3.

Similarly, I cannot save the angles at the end of the reconstruction. When it try to create the file it crash

fredboudon commented 1 year ago

Thanks for this report. I will try to fix it for the next version of plantscan3d

Micbut commented 1 year ago

Thank you, the following is the error log when I try to save plantscan3d.log

Micbut commented 1 year ago

And the following is the error log when I try to export the angles: plantscan3d.log

Micbut commented 1 year ago

Could it be that I face these issues with saving because I have the version 1.2.2 of PlantScan3d?

I tryied to update to 1.2.3 and 1.3.0 (that seem to be available) but I get the following error: Screenshot 2022-11-24 165924 Screenshot 2022-11-24 163806

Micbut commented 1 year ago

This is what I find in the .log file

1.3.0

2023-01-23, 18:42:35

<class 'PermissionError'>: [Errno 13] Permission denied: '/'

File "c:\users\buttu001.conda\envs\openale\lib\site-packages\openalea.plantscan3d-1.3.0-py3.9.egg\openalea\plantscan3d\main_viewer.py", line 2896, in angleEstimate write_phylo_angles(str(fname[0]), phyangles, nodelength) File "c:\users\buttu001.conda\envs\openale\lib\site-packages\openalea.plantscan3d-1.3.0-py3.9.egg\openalea\plantscan3d\angleanalysis.py", line 113, in write_phylo_angles f = open(output_phy,'w')

fredboudon commented 1 year ago

Can you try to save your data into a file whose name has no space. For instance into C:/tmp. Just to check if the pb occurs because of bad filename management.

Micbut commented 1 year ago

I tried, and it doesn't give me error, however the file is not created

Micbut commented 1 year ago

Please let me know if you need other information

Micbut commented 1 year ago

2 of my colleagues manage to solve the issue of exporting.

The find and error within main_viewer.py before: image

after: image

However now I stuggle interpreting the content of the file

this is what I see: image

how do I relate thi angle to the following structure?

image

fredboudon commented 1 year ago

In theory, there should be a main line representing the trunk and secondary lines representing the second order branches. They should have been displayed. The phyllotactic angles are then evaluated. They are given in absolute (relative to OX if I remember well) or in relative (difference of angle between 2 consecutives branches) either in clock wise order or in counter clock wise order. The internode length is also estimated (and not the node length). Hope it helps for the interpretation. I will check the visual representation of it.

Micbut commented 1 year ago

Thank you: does it also provide inclination angles? With respect to the central vertical axis. That would be a very very valuable info

Micbut commented 1 year ago

In theory, there should be a main line representing the trunk and secondary lines representing the second order branches. They should have been displayed. The phyllotactic angles are then evaluated. They are given in absolute (relative to OX if I remember well) or in relative (difference of angle between 2 consecutives branches) either in clock wise order or in counter clock wise order. The internode length is also estimated (and not the node length). Hope it helps for the interpretation. I will check the visual representation of it.

Unfortunately the output file generated misses some lines - I think there are few mistakes in the code that should be fixed. One feature that would be extremely useful is to export the angles in an MTG format. Because now the MTG file is not that useful because it describes the topology of the nodes and not of the Internodes.

If we could export an MTG that describes the topology of the internodes AND for each internode (in the attributes columns) the angles and the length would be fantastic