search

fredcy / moodle-tool_datatables

Moodle plugin providing DataTables features to HTML tables
GNU General Public License v3.0
3 stars 3 forks source link

Refactoring this plugin to local/datatables (security reasons) #7

Open nadavkav opened 3 years ago

nadavkav commented 3 years ago

Hello, Our security team recently started blocking the admin folder from all non admin users, including the folder admin/tool/datatables :-( Is there any specific reason this plugin should be under admin/tool folder? Can I move it (and refactor it) to local/datatables? (would that be OK with you?)

fredcy commented 3 years ago

It's fine with me to move it as you describe. I put it in admin not knowing of a better place at the time.

My organization has moved away from using Moodle -- 😞 -- and so I don't plan on doing further work on this plugin. Might be best to fork it.

nadavkav commented 3 years ago

Thank you @fredcy for your quick reply. I have already moved it to local/datatables, and it works fine :smiley:

Sorry to read that your organization moved from Moodle. I will probably fork it, as you suggested, and keep a link to your original repo, and give proper credit! Thank you for a great plugin!

nadavkav commented 3 years ago

A while ago, I suggested Moodle core should integrate datatables everywhere https://tracker.moodle.org/browse/MDL-60690 And just recently, it seem Moodle 4 will include it in core https://tracker.moodle.org/browse/MDL-72038