search

freddiehaddad / feline.nvim

A minimal, stylish and customizable statusline, statuscolumn, and winbar for Neovim
GNU General Public License v3.0
289 stars 8 forks source link

Fix illegal character issue in feline.nvim generator.lua #45

Closed fagundesraphael closed 10 months ago

fagundesraphael commented 10 months ago

Hi Freddie 👋🏽

I hope you're doing well! I encountered a minor issue in Feline where an unexpected character ("< >") appears. After some investigation, I found that this issue specifically occurs with Java files. I made a quick fix that seems to work.

Consider the possibility of adding a function to handle such characters or providing a config option for customization. This could enhance the overall flexibility of Feline.

Cheers, Raphael

fagundesraphael commented 10 months ago

feline

freddiehaddad commented 10 months ago

Hello! Thank you for reporting the issue and providing a fix. I can see in the screenshot the error. I'm curious as to what your config looks like. Would you mind sharing it? Specifically the feline part.

Also, can I have you make a minor change to the commit message? For semver to work correctly, the prefix needs to be fix:. I can amend the commit myself and merge also.

Thank you!

fagundesraphael commented 10 months ago

Hi, 👀

Thank you so much for your prompt response and attention to the issue. I appreciate the time you took to look into the matter. After further investigation, I realized that the problem is related to the catppuccin theme, which is not officially supported by Feline.

Warning Currently feline https://github.com/feline-nvim/feline.nvim/issues/302. In order for :colorscheme catppuccin- to work you could add this autocmd as a workaround

Given this, I've decided to retract the pull request as the issue seems to be specific to the theme I'm using. I wanted to express my gratitude for your willingness to assist and for the fantastic work you do on Feline.

If there's anything specific you'd like me to do or test regarding the theme compatibility or if you have any suggestions, please feel free to let me know.

Thanks again for your time and support! 👋🏽

Best regards, Raphael

freddiehaddad commented 10 months ago

Thanks for referencing the issue with the theme. I'm going to look at it closer and see what can be done to avoid it.

I am planning to make some changes in the theme area of feline to make playing with different color schemes work better.

Thanks!