freddiehaddad / feline.nvim

A minimal, stylish and customizable statusline, statuscolumn, and winbar for Neovim
GNU General Public License v3.0
310 stars 10 forks source link

> Hi @freddiehaddad! The commit [1dcf6bf](https://github.com/freddiehaddad/feline.nvim/commit/1dcf6bf0b7fcaf2a2cddec377266eb2e6a41492e) broke my custom git component that looks like this: #59

Closed freddiehaddad closed 11 months ago

freddiehaddad commented 11 months ago
          > Hi @freddiehaddad! The commit [1dcf6bf](https://github.com/freddiehaddad/feline.nvim/commit/1dcf6bf0b7fcaf2a2cddec377266eb2e6a41492e) broke my custom git component that looks like this:
{
  provider = 'git_branch',
  icon = {
    str = '  ', -- Custom git icon
    hl = { fg = '#f34f29' },
  },
}

The default icon is now used instead of the custom one, and the custom highlight is no longer applied.

Is this expected behaviour?

Hm.. That's strange. I tested your case explicitly w/o issue. Mind sharing your config so I can test it? At first glance, I don't see why it's failing.

EDIT:

The default component.icon table is merged with yours and should keep your settings instead of the default. I might need to look at the remaining providers as there could be a case I missed.

To answer your question, it should have been a non-breaking change. I will address it.

Originally posted by @freddiehaddad in https://github.com/freddiehaddad/feline.nvim/issues/49#issuecomment-1828215254