freddiehaddad / feline.nvim

A minimal, stylish and customizable statusline, statuscolumn, and winbar for Neovim
GNU General Public License v3.0
310 stars 10 forks source link

`:Rocks sync` fails on feline.nvim if ssh key has passphrase #78

Closed Anrock closed 6 months ago

Anrock commented 6 months ago

Did you check docs and existing issues?

Neovim version (nvim -v)

NVIM v0.10.0-dev-2937+g8e5c48b08-dirt

Operating system/version

Gentoo

Describe the bug

:Rocks sync tries to git clone feline, feline rockspec has ssh+git url, so git tries to read ssh key but it has a passphrase and luarocks or rocks.nvim can't handle that, failing install.

This was first reported to rocks.nvim, got moved to nvim-neorocks and closed there with suggestion to create an issue to feline repo with suggested fix of "change the source URL to HTTPS". Here I am ._.

Steps To Reproduce

:Rocks install feline.nvim, also have a passphrase on your ssh key.

Expected Behavior

Installs feline.nvim

Repro

require("lazy").setup({
  {
    "freddiehaddad/feline.nvim",
    config = function()
      -- your configuration
    end,
  }
})
freddiehaddad commented 6 months ago

I see the spec file uses ssh instead of https. I'll switch that and follow up.

freddiehaddad commented 6 months ago

I just updated the rockspec file. Can you confirm things work?

Anrock commented 6 months ago

Just installed dev version with no issue. Thank you!

Also, back in https://github.com/nvim-neorocks/luarocks-tag-release/issues/405 it was suggested to use feline 1.5.1 release which didn't have that issue since it was published using luarocks-tag-release. Just fyi.

freddiehaddad commented 6 months ago

Okay, that makes sense since I deleted the spec file that was part of the repo and I think responsible for the dev version. Thank you for verifying!