search

freddy36 / check_mk_extensions

Extensions for check_mk
GNU General Public License v3.0
11 stars 10 forks source link

Malformed agent output #1

Closed Dragonn closed 10 years ago

Dragonn commented 10 years ago

At first, thank you for this plugin, it looks really great.

Unfortunately output of agent is probably malformed to me. Comment in python file checks/bird.include says output should look like:

<<>> 0001 BIRD 1.4.3 ready. 1000 BIRD 1.4.3 1011 Router ID is 192.0.2.125 1011 Current server time is 2014-06-05 16:26:52 1011 Last reboot on 2014-06-02 17:15:23 1011 Last reconfiguration on 2014-06-03 14:37:54 0013 Daemon is up and running

But my output look like:

<<>> 0001 BIRD 1.4.4 ready. 100 BIRD 1.4.4 101 Router ID is 192.168.110.66 101 Current server time is 2014-07-28 13:10:11 101 Last reboot on 2014-07-28 12:14:53 101 Last reconfiguration on 2014-07-28 12:14:53 0013 Daemon is up and running

I am using current version of your plugin. Tried bird v1.4.0 and 1.4.4 (current) but no change.

Please can you help me or give some advice?

EqO commented 10 years ago

Hi! I can confirm this. Same behavior on Debian wheezy. Problem is in check_mk_agent plugin. The content of variable MODIFIER is constructed using AWK's function substr() whose is saying "The first character of a string is character number one." But here zero is used as index of first character incorrectly.

The fix is to change line in check_mk_agent file to look like this: MODIFIER='{if($1 ~ /^[0-9][0-9][0-9][0-9]-/) {code=substr($1,1,4);print code, s ubstr($0,6)} else if ($0 ~ /^ /) {print code $0} else {print}}'

On my system awk -W version returns: mawk 1.3.3 Nov 1996

I hope it will help.

freddy36 commented 10 years ago

Should be fixed with 11f6e082147928e2651abdd07b37ff0fe295f941 Just reinstall the agent (directly from git, no new packages available yet). Thank you EqO