search

freddychenyouren2 / pe

0 stars 0 forks source link

Is there supposed to be a List of JsonAdaptedPerson in the constructor of a JsonAdaptedGroup? #11

Open freddychenyouren2 opened 7 months ago

freddychenyouren2 commented 7 months ago

Given the following code from JsonAdaptedGroup.java for ProjectPRO as retrieved from https://github.com/AY2324S1-CS2103T-T10-3/tp/blob/master/src/main/java/seedu/address/storage/JsonAdaptedGroup.java

image.png

However, in the Sotrage Class Diagram in Developer Guide, there seems to be an arrow pointing from JsonAdaptedGroup to JsonAdaptedPerson with Multiplicity of *

image.png

Then should there have been JsonAdaptedPerson for the constructor of JsonAdaptedGroup? Or should there have been no said arrow in the Storage Class Diagram? This appeared ambiguous to me acting as a potential future developer. This is because for the reverse arrow: from JsonAdaptedGroup to JsonAdaptedPerson, it turns out that the constructor of JsonAdaptedPerson accepts a list of JsonAdaptedGroup.

image.png

soc-pe-bot commented 7 months ago

Your response not required for this bug as the team has accepted the bug as it is.