search

freddychenyouren2 / pe

0 stars 0 forks source link

Name of contacts are allowed to be fully numerical #6

Open freddychenyouren2 opened 7 months ago

freddychenyouren2 commented 7 months ago

Commands tested:

add n/123 p/999 e/email@yes

add n/234 p/998 e/email+yeet@gg.com

As can be seen in the screenshots, names of contacts are allowed to be fully numerical, which I believe is not one of the intended constraint of Name, within the context of the target audience, even though the given constraint is for name to be Alphanumerical.

image.png

nus-se-script commented 7 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

We feel that since users usually have the freedom to choose how to save their contacts (be it fully alphabetical or using numbers), this error is not a valid one.

Also this simulates the contact list in our phones where we can save a contact as a number, and it is not limited to just alphabets. Thus, we feel that the input checking for names should not be so stringent as it may be overzealous to disallow such inputs.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]