search

freddyz / computerscare-vcv-modules

Modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
42 stars 10 forks source link

LaundrySoup 1.2.0 does NOT recall old patches #33

Closed Petervos2018 closed 4 years ago

Petervos2018 commented 4 years ago

This is the original patch : ScareOld

And after updating to 1.2.0 it looks (and sounds) like this :

ScareNew

And the sixth row is always different with every new LaundrySoup, maybe intentional as a nice random setting?

Greetings Peter.

freddyz commented 4 years ago

Dang I thought I fixed that. Could you upload the .vcv file?

Petervos2018 commented 4 years ago

Sure it a big patch but maybe it's useful to you

Lulu rouge 64-4 rithm - 13092019-3Automation3 TEMP2.zip

Greetings Peter.

freddyz commented 4 years ago

Thanks. Also, which platform are you running Rack on?

The 6th row random initial formula is intentional, but obviously overwriting your previous values is not!

Petervos2018 commented 4 years ago

Windows 7 And I guessed the random row was a nice touch :+1:

Petervos2018 commented 4 years ago

I'm on Win 10 now and I still have this issue.

freddyz commented 4 years ago

Thanks for the update. Is this the case for any patch with Laundry Soup, or just the patch you uploaded above?

Petervos2018 commented 4 years ago

To be honest I "THINK" it goes wrong with all the Laundry soups prior to 1.2.0. , but I have not tried this, furthermore I "THINK" that when I save a patch with 1.2.0 and recall it it will probably be OK. But it's a lot of work deleting the folder swapping them out etc....

Greetings Peter (maybe I'll try it later)

Petervos2018 commented 4 years ago

Yep just tested it's EXACTLY like I wrote above and here are 2 simple patches one made with 111 the other with 120 they both should go from 10 (top) to 5 (bottom) and depending on what version you have installed the 111 reads them both the right way, 120 Fux the 111 up and loads the 120 OK.

Greetings Peter.

patches-v1.zip

freddyz commented 4 years ago

Do I have this correct?

Laundry Soup Patch Version Running Computerscare Modules 1.1.1 Running Computersare modules 1.2.0
1.1.1 Loads properly Does not load properly
1.2.0 Loads properly Loads properly

Thanks a lot for testing this!

Petervos2018 commented 4 years ago

Yes that is a very nice representation of the nonsense I wrote above. 👍

freddyz commented 4 years ago

Thanks for sending those patch files - now I can reproduce the problem and I see that it affects some other parts of Laundry soup as well.

Petervos2018 commented 4 years ago

Thank you for investigating 👍

freddyz commented 4 years ago

Alright I think I've fixed the problem. You can test it out with a build of 1.3.0 here: https://github.com/freddyz/computerscare-vcv-modules/releases/tag/v1.3.0

Petervos2018 commented 4 years ago

Yes that did it, well done Adam/freddyz thank you for sorting this out (for me). I'm gonna close this one NOW. Greetings Peter.