search

freddyz / computerscare-vcv-modules

Modules for VCV Rack
BSD 3-Clause "New" or "Revised" License
41 stars 9 forks source link

Is frame advance not working ? #77

Open jpnielsen opened 2 years ago

jpnielsen commented 2 years ago
image

My counter works with NYSTHI modules, but I can't figure out if I'm doing something wrong or I found a bug.

999_nixie_counter.zip

https://en.wikipedia.org/wiki/Nixie_tube#/media/File:Nixie2.gif

freddyz commented 2 years ago

I think the problem is you had the animation disabled via right click menu. Your patch is working as expected for me when I clicked the "animation enabled" option:

Screen Shot 2021-12-12 at 10 43 47 AM
jpnielsen commented 2 years ago

But then it's running even when there is no clock ?

freddyz commented 2 years ago

If you have a cable connected to the Blank Expander top input (frame/sync/scan) the animation will not automatically play. In your case, it will wait for a clock signal before advancing the frame. If the "animation enabled" is unchecked, the animation will never advance no matter what is happening with the clock input.

jpnielsen commented 2 years ago

Ah - I just pulled the cable out - and then it continued - "normalled" inputs sometimes "gets" me.

Thank you so much.

jpnielsen commented 2 years ago

When I send a reset trig, the module also sends the EOC (when EOC=#1, my "ZERO" in the gif) to increment the next module.. This results in "1 1 0" displayed after a reset.

Used an AND gate to only forward the EOC "carrier" when the counter is running.

image

Perhaps the module should not send EOC on reset if EOC=#1.

How would you make a counter ?

999_nixie_counter_v2.zip

freddyz commented 2 years ago

I see what you mean, I will look into it. I'm thinking the solution is to have the expander ignore clock triggers for 1ms after a reset signal. This is how sequencers are supposed to behave per the documentation: https://vcvrack.com/manual/VoltageStandards#Timing

freddyz commented 2 years ago

I believe I've fixed the problem. Now a single reset trigger should properly reset all instances of customblank when they are chained together. @jpnielsen if you would be able to test the automated build with your patch, I'd appreciate it! Check the "artifacts" section here and you can install the dev build for your platform: https://github.com/freddyz/computerscare-vcv-modules/actions/runs/1624415735

jpnielsen commented 2 years ago

Works fine now - thanks.

freddyz commented 2 years ago

Excellent, thank you for the report and the investigation!