Null safety migration - Githubissues

fredeil / email-validator.dart

A simple Dart class for validating email addresses (syntax) without using RegEx :email:

https://pub.dartlang.org/packages/email_validator

MIT License

195 stars 38 forks source link

Null safety migration #16

Closed fredeil closed 3 years ago

fredeil commented 3 years ago

Changes :balloon:

Migrate to null safety (https://dart.dev/null-safety/understanding-null-safety)

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist :heavy_check_mark:

[x] I have read the coding convention guidelines and my code follows these.
[x] Unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

fredeil commented 3 years ago

Thank you for the review @lrhn. The transition was quite easy, there is not much code after all!

What's next?

zepfietje commented 3 years ago

@fredeil is this ready to be merged and published as a null-safe prerelease version?

fredeil commented 3 years ago

@fredeil is this ready to be merged and published as a null-safe prerelease version?

Yes, almost. Probably must update dart version in the manifest

fredeil commented 3 years ago

@zepfietje are you interested in getting it done?

zepfietje commented 3 years ago

@fredeil I'd gladly do it, but I don't think it makes sense to start working on a separate PR for just updating the sdk and package versions, right?

fredeil commented 3 years ago

@zepfietje you can continue on this branch even if the PR is up 😁