search

frederickjansen / polyline

A Python implementation of Google's Encoded Polyline Algorithm Format.
http://goo.gl/PvXf8Y
MIT License
114 stars 19 forks source link

Relax PEP 517 build dependencies #15

Closed tjni closed 1 year ago

tjni commented 1 year ago

I noticed a couple of things when working on this package for nixpkgs:

  1. setuptools is already at version 68.1.2. Given how fast it iterates, would you be OK with not capping the version unless it releases a version that we find out breaks the build?

  2. build is a PEP 517 build front-end (which we are using also), but it's not a requirement for setuptools to build the package (unless I am misunderstanding something)

  3. wheel does not need to be listed explicitly. From the setuptools documentation:

Historically this documentation has unnecessarily listed wheel in the requires list, and many projects still do that. This is not recommended. The backend automatically adds wheel dependency when it is required, and listing it explicitly causes it to be unnecessarily required for source distribution builds. You should only include wheel in requires if you need to explicitly access it during build time (e.g. if your project needs a setup.py script that imports wheel).

frederickjansen commented 1 year ago

Thanks, these changes make sense! I'll release a v2.0.1 build soon.

derekstraka commented 12 months ago

@frederickjansen - Any chance we can get an updated release? I'm maintaining the embedded distro layer meta-python, and I'd prefer to not carry this patch. Do you have any thoughts on a 2.0.1 release? Thanks for all your contributions!

frederickjansen commented 12 months ago

Hi @derekstraka, sorry about that. I'll release v2.0.1 this weekend.

frederickjansen commented 11 months ago

@derekstraka v2.0.1 is now released