search

frederickpek / pe

0 stars 0 forks source link

Incorrect error message when using large index value #4

Open frederickpek opened 2 years ago

frederickpek commented 2 years ago

When trying to index clients for a large value (presumably larger than interger max int), the error message indicates that the command is keyed with an invalid format. This is not the case.

image.png

Validation regex could be used to first check if the string is indeed all interger values, then try to parse and catch NumberFormatException.

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong error being displayed when Index exceeds Max Int

For the command Index field, input a number that whose absolute value is greater than the max integer value 2147483647.

Eg. 2147483648, or its negative counterpart -2147483648

Same error for other commands.

Screenshot 2021-11-12 at 4.29.39 PM.png

[original: nus-cs2103-AY2122S1/pe-interim#4895] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]