fredericojssilva / ShowTipsView

Highligth specific points of interest of your app
Apache License 2.0
598 stars 106 forks source link

setTitleColor and setCircleColor bring to unpredictable results #14

Open MarKco opened 8 years ago

MarKco commented 8 years ago

Hello, I noticed that when I set titleColor and circleColor I get strange results.

This is what I get without specifying any color:

    ShowTipsView showtips = new ShowTipsBuilder(MyActivity.this)
            .setTarget(myLayout)
            .setTitle("Completamento automatico dei nomi")
            .setDescription("Selezionando la casella \"Salva i nomi dei passeggeri\" i nominativi verranno salvati per le prossime prenotazioni")
            .setButtonText(getResources().getString(R.string.ok))
            .setCloseButtonTextColor(R.color.black)
            .setButtonBackground(ContextCompat.getDrawable(getApplicationContext(), R.color.LightGrey))
            .setBackgroundAlpha(94)
            .build();

screenshot_2016-07-21-16-22-24

If I specify a circleColor and a titleColor I'd expect to see them applied. Actually, it seems to revert back to some default.

    ShowTipsView showtips = new ShowTipsBuilder(MyActivity)
            .setTarget(myLayout)
            .setCircleColor(R.color.white)
            .setTitle("Completamento automatico dei nomi")
            .setTitleColor(R.color.hc_red)
            .setDescription("Selezionando la casella \"Salva i nomi dei passeggeri\" i nominativi verranno salvati per le prossime prenotazioni")
            .setDelay(500)
            .setButtonText(getResources().getString(R.string.ok))
            .setCloseButtonTextColor(R.color.black)
            .setButtonBackground(ContextCompat.getDrawable(getApplicationContext(), R.color.LightGrey))
            .setBackgroundAlpha(94)
            .build();

screenshot_2016-07-21-16-22-07

This happens as well if I apply some default color as R.color.common_plus_signin_btn_text_light instead of R.color.hc_red, which is customized.

fredericojssilva commented 8 years ago

nice catch @MarKco. I will fix it as soon as I can. Thanks